You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/09 04:55:16 UTC

[GitHub] ChaiBapchya commented on a change in pull request #14097: Relaxing type requirements for slice_like op

ChaiBapchya commented on a change in pull request #14097: Relaxing type requirements for slice_like op
URL: https://github.com/apache/incubator-mxnet/pull/14097#discussion_r255287580
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -2515,6 +2515,20 @@ def test_slice_like():
             assert_allclose(xx, xgrad.asnumpy())
             assert_allclose(xgrad1.asnumpy(), mx.nd.zeros_like(xgrad1).asnumpy())
 
+@with_seed()
+def test_slice_like_different_types():
+    x = [[  1.,   2.,   3.,   4.],
 
 Review comment:
   Though this example looks good, I am afraid it is specific. Do you mind using randomized shape, size and NDarray initalization to ensure this is generic?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services