You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/13 16:05:56 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r470062219



##########
File path: cpp/src/arrow/buffer_builder.h
##########
@@ -292,6 +292,11 @@ class TypedBufferBuilder<bool> {
     return Status::OK();
   }
 
+  void AppendEmpty(int64_t num_elements) {

Review comment:
       We must not leave elements undefined in an array, because it can reveal previous data. "Empty" values here should still be non-null values of arbitrary value (but still well-defined).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org