[GitHub] [airflow] ferruzzi edited a comment on issue #14396: Make context less nebulous

[GitBox <gi...@apache.org>]

ferruzzi edited a comment on issue #14396:
URL: https://github.com/apache/airflow/issues/14396#issuecomment-959459628


   Looking at maybe taking this on.    I also had a good bit of "what the heck is even IN `context` and what's it for?" when I first started looking at the codebase, so I can see the benefit to new contributors and it'll be a good one to learn, myself.
   
   1) Would the ideal solution be to make a new module under `airflow.models` to define the Context TypedDict and import it into `taskinstance.py`, or just define it at the top of `airflow.models.taskinstance`?
   
   2) If/once I do define the TypedDict, are any other changes needed in order to implement it?   I have a rough implementation locally already and it seems to pass CI without any further changes, but want to make sure I'm not underestimating the scope of this.
   
   3) Context appears to contain some other Dicts (`conf` and `var`, specifically), should I chase that rabbit and define those as well while I am at it?
   
   4) It looks like we use both `datetime.datetime` and `pendulum.DateTime` in various places, which would we prefer to use here in the Context definition for the various timestamp fields?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org