[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1443: [core] Support rollback to a tag

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1443:
URL: https://github.com/apache/incubator-paimon/pull/1443#discussion_r1250445983


##########
paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java:
##########
@@ -119,6 +157,65 @@ public SortedMap<Snapshot, String> tags() {
         return tags;
     }
 
+    /** Rollback to tag. */
+    public void rollbackTo(String tagName, Snapshot latestSnapshot, TagDeletion tagDeletion) {

Review Comment:
   Introduce a real `rollbackTo(long snapshotId)`, delete all tags and all snapshots bigger than it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org