[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20320: [FLINK-28519][network] Fix the bug that SortMergeResultPartitionReadScheduler may not read data sequentially

[GitBox <gi...@apache.org>]

TanYuxin-tyx commented on code in PR #20320:
URL: https://github.com/apache/flink/pull/20320#discussion_r926310001


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartitionReadScheduler.java:
##########
@@ -283,13 +284,26 @@ private void mayNotifyReleased() {
         }
     }
 
-    private Queue<SortMergeSubpartitionReader> getAvailableReaders() {
+    private Queue<SortMergeSubpartitionReader> getAllReaders() {
         synchronized (lock) {
             if (isReleased) {
                 return new ArrayDeque<>();
             }
+            return new ArrayDeque<>(allReaders);
+        }
+    }
 
-            return new PriorityQueue<>(allReaders);
+    @Nullable
+    private SortMergeSubpartitionReader getNextReaderToRead(

Review Comment:
   OK, renamed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org