[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2647: Consolidated duplicate Thrift client code

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2647:
URL: https://github.com/apache/accumulo/pull/2647#discussion_r872030000


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -312,16 +312,16 @@ private String waitForFateOperation(long opid)
         log.debug("Contacted a Manager which is no longer active, retrying");
         sleepUninterruptibly(100, MILLISECONDS);
       } finally {
-        FateManagerClient.close(client, context);
+        ThriftUtil.close(client, context);
       }
     }
   }
 
   private void finishFateOperation(long opid) throws ThriftSecurityException, TException {
     while (true) {
-      FateService.Iface client = null;
+      FateService.Client client = null;

Review Comment:
   As a follow-on, it might be nice to put all these direct uses of the Clients into the `ThriftClientTypes.CLIENT.execute(...)` pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org