You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2023/08/03 05:23:17 UTC

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #33057: fix: Consider custom pod labels on pod finding process on KubernetesPodOperator

amoghrajesh commented on code in PR #33057:
URL: https://github.com/apache/airflow/pull/33057#discussion_r1282658641


##########
tests/providers/cncf/kubernetes/operators/test_pod.py:
##########
@@ -327,7 +327,7 @@ def test_find_pod_labels(self):
         self.run_pod(k)
         _, kwargs = k.client.list_namespaced_pod.call_args
         assert kwargs["label_selector"] == (
-            "dag_id=dag,kubernetes_pod_operator=True,run_id=test,task_id=task,"
+            "dag_id=dag,foo=bar,kubernetes_pod_operator=True,run_id=test,task_id=task,"

Review Comment:
   Rather can we have a different test case that searches by label params and leave this test case, as-is?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org