You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/09/25 17:41:02 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #1505: Hive: Make HiveCatalog based tables automatically readable from Hive
rdblue commented on a change in pull request #1505:
URL: https://github.com/apache/iceberg/pull/1505#discussion_r495138301
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -169,6 +171,15 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
tbl.getParameters().put("EXTERNAL", "TRUE"); // using the external table type also requires this
}
+ // If needed set the required properties on the table to be able to query from Hive
+ if (hiveEngineEnabled(metadata, conf)) {
Review comment:
I think this should be in the `storageDescriptor` method instead of here in the commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org