[GitHub] [tinkerpop] dzmitry-lahoda edited a comment on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse

[GitBox <gi...@apache.org>]

dzmitry-lahoda edited a comment on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse
URL: https://github.com/apache/tinkerpop/pull/1247#issuecomment-588212659
 
 
   > Parse and we notify the response handler about the exception.
   
   Will not because message is null. There there is silent error eating. 
   
   Could we just check that deserialized object is not null and throw exception.
   
   ```
          var receivedMsg = _messageSerializer.DeserializeMessage<ResponseMessage<JToken>>(received);
               if (receivedMsg == null)
               {
                   throw new Exception("receivedMsg");
               }
   ```
   
   To check what happens in case of null array passed, in case of empty array passed, and do property based testing for any other array passed. So it will be more explainable failure than just eating null.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services