You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2013/02/28 03:42:03 UTC
Review Request: Support the on render event for pubsub gadgets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9668/
-----------------------------------------------------------
Review request for shindig.
Description
-------
Currently pubsub gadgets called the on render event but did not pass the gadget url or site id to the on render function. With the recent change to call the sites onrender event, the lack of the site id being passed to the on render event causes a JS error.
This addresses bug SHINDIG-1909.
https://issues.apache.org/jira/browse/SHINDIG-1909
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.7/iframe.js 1451075
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1451075
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1451075
Diff: https://reviews.apache.org/r/9668/diff/
Testing
-------
Tested in common container
Thanks,
Ryan Baxter
Re: Review Request: Support the on render event for pubsub gadgets
Posted by Marshall Shi <sh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9668/#review17185
-----------------------------------------------------------
Ship it!
Ship It!
- Marshall Shi
On Feb. 28, 2013, 2:42 a.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9668/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 2:42 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently pubsub gadgets called the on render event but did not pass the gadget url or site id to the on render function. With the recent change to call the sites onrender event, the lack of the site id being passed to the on render event causes a JS error.
>
>
> This addresses bug SHINDIG-1909.
> https://issues.apache.org/jira/browse/SHINDIG-1909
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.7/iframe.js 1451075
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1451075
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1451075
>
> Diff: https://reviews.apache.org/r/9668/diff/
>
>
> Testing
> -------
>
> Tested in common container
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request: Support the on render event for pubsub gadgets
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9668/#review17212
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On Feb. 28, 2013, 2:42 a.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9668/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 2:42 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently pubsub gadgets called the on render event but did not pass the gadget url or site id to the on render function. With the recent change to call the sites onrender event, the lack of the site id being passed to the on render event causes a JS error.
>
>
> This addresses bug SHINDIG-1909.
> https://issues.apache.org/jira/browse/SHINDIG-1909
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.7/iframe.js 1451075
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1451075
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1451075
>
> Diff: https://reviews.apache.org/r/9668/diff/
>
>
> Testing
> -------
>
> Tested in common container
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request: Support the on render event for pubsub gadgets
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9668/#review17209
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On Feb. 28, 2013, 2:42 a.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9668/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 2:42 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently pubsub gadgets called the on render event but did not pass the gadget url or site id to the on render function. With the recent change to call the sites onrender event, the lack of the site id being passed to the on render event causes a JS error.
>
>
> This addresses bug SHINDIG-1909.
> https://issues.apache.org/jira/browse/SHINDIG-1909
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.7/iframe.js 1451075
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1451075
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1451075
>
> Diff: https://reviews.apache.org/r/9668/diff/
>
>
> Testing
> -------
>
> Tested in common container
>
>
> Thanks,
>
> Ryan Baxter
>
>