[jira] Commented: (THRIFT-261) BinaryProtocolAccelerated doesn't call #validate on nested structs

["Kevin Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664726#action_12664726 ] 

Kevin Clark commented on THRIFT-261:
------------------------------------

Code looks fine. Might be nice to intern "validate" in the Init_ hook instead of the function though. A test would also be good.

> BinaryProtocolAccelerated doesn't call #validate on nested structs
> ------------------------------------------------------------------
>
>                 Key: THRIFT-261
>                 URL: https://issues.apache.org/jira/browse/THRIFT-261
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>         Attachments: thrift-261.patch
>
>
> The trunk version of BinaryProtocolAccelerated doesn't cal #validate on nested structs, meaning that validation is not properly carried out. The top-level struct is still validated, though, because control doesn't pass from the struct to the protocol until after the validation check. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.