[GitHub] [iotdb] Beyyes commented on a diff in pull request #7306: [IOTDB-4370] Refactor RegionGroup's creation process and build RegionGroup maintain thread

[GitBox <gi...@apache.org>]

Beyyes commented on code in PR #7306:
URL: https://github.com/apache/iotdb/pull/7306#discussion_r972868558


##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/ConfigNodeProcedureEnv.java:
##########
@@ -114,6 +113,10 @@ public TSStatus deleteConfig(String name) {
     return getClusterSchemaManager().deleteStorageGroup(deleteStorageGroupPlan);
   }
 
+  public List<TRegionReplicaSet> getAllReplicaSets(String storageGroup) {

Review Comment:
   Put all get method in the bottom is tidy



##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/ConfigPhysicalPlanType.java:
##########
@@ -32,6 +32,8 @@ public enum ConfigPhysicalPlanType {
   GetStorageGroup,
   CountStorageGroup,
   CreateRegionGroups,
+  OfferRegionMaintainTasks,

Review Comment:
   Changes the ordinal of ConfigPhysicalPlanType, may produce serialize problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org