[incubator-superset] branch master updated: fix: alembic migration error msg trying to delete constraint on tables (#11115)

[dp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 50d8040  fix: alembic migration error msg trying to delete constraint on tables (#11115)
50d8040 is described below

commit 50d80405a90c9c79f2a00b2c22cc6c1fdc333012
Author: Daniel Vaz Gaspar <da...@gmail.com>
AuthorDate: Thu Oct 1 12:35:12 2020 +0100

    fix: alembic migration error msg trying to delete constraint on tables (#11115)
    
    * fix: alembic migration fails by deleting non existent constraint on tables
    
    * Revert "fix: alembic migration fails by deleting non existent constraint on tables"
    
    This reverts commit 3a359b0577f4bf33992c3de2d54e8546bd3d216f.
    
    * mantain migration but just for MySQL and add downgrade procedure
    
    * skip the downgrade
---
 .../versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py b/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
index f4c5af1..c011c06 100644
--- a/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
+++ b/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py
@@ -27,15 +27,15 @@ revision = "18532d70ab98"
 down_revision = "3fbbc6e8d654"
 
 from alembic import op
+from sqlalchemy.dialects.mysql.base import MySQLDialect
 
 
 def upgrade():
-    try:
+    bind = op.get_bind()
+    if isinstance(bind.dialect, MySQLDialect):
         # index only exists in mysql db
         with op.get_context().autocommit_block():
             op.drop_constraint("table_name", "tables", type_="unique")
-    except Exception as ex:
-        print(ex)
 
 
 def downgrade():