You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by johnament <gi...@git.apache.org> on 2015/06/15 02:01:36 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...
GitHub user johnament opened a pull request:
https://github.com/apache/activemq-artemis/pull/27
ARTEMIS-103 Changed JGroupsBroadcastEndpoint to not close its JChanne…
…l since its externally managed. Added javadocs to impacted areas to clarify that the JChannel is not closed by these implementations.
I considered also changing the close behavior to take a second argument to determine whether the channel should be closed. I chose this approach since it seems to be specific to RAs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnament/activemq-artemis ARTEMIS-103
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 3710b3aa3c81d3628b3ba4d209cd06d393becf65
Author: John D. Ament <jo...@apache.org>
Date: 2015-06-14T23:59:28Z
ARTEMIS-103 Changed JGroupsBroadcastEndpoint to not close its JChannel since its externally managed. Added javadocs to impacted areas to clarify that the JChannel is not closed by these implementations.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/27#issuecomment-111905065
Why I can't assign you tasks. You are not an activemq committer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/activemq-artemis/pull/27#issuecomment-111905436
@clebertsuconic that's one of the pains with the ASF setup for github, need to push to the ASF git repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/27#issuecomment-111905254
Looks good btw. Will merge it as soon as I get to a computer (using an iPad now )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/activemq-artemis/pull/27#issuecomment-111905386
@clebertsuconic nope, not a committer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---