[GitHub] [activemq-nms-api] Havret opened a new pull request #11: Restore session extensions api

[GitBox <gi...@apache.org>]

Havret opened a new pull request #11: Restore session extensions api
URL: https://github.com/apache/activemq-nms-api/pull/11
 
 
   This PR addresses a change requested via mailing list. Waiting for Jira Issue.
   
   > I have tried updating the Apache.ActiveMQ.NMS Nuget package to 1.8.0 in my
   > project, and am getting build errors indicating that the GetDestination
   > method is not available on ISession.
   > 
   > This method is defined in the SessionExtensions class, but it is
   > conditionally compiled only if the symbol MONO or NET_3_5 is defined.
   > 
   > I assume that this was defined previously, but is now inadvertently omitted
   > as part of the restructuring that was done for 1.8. Probably, the extension
   > methods could be defined for any supported version of .NET at this point,
   > as .NET < 3.5 is no longer supported by the project.
   > 
   > The extension method simply delegates to SessionUtil.GetDestination, which
   > is exposed to public as well, so for my immediate need I just called that
   > directly.
   > However, I assume this should not have been necessary and that the
   > extension methods should still be provided as before, rather than have a
   > breaking change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services