You are viewing a plain text version of this content. The canonical link for it is here.
Posted to taglibs-dev@jakarta.apache.org by ba...@apache.org on 2002/10/14 04:47:23 UTC
cvs commit: jakarta-taglibs/string/src/org/apache/taglibs/string StringTagSupport.java
bayard 2002/10/13 19:47:23
Modified: string/src/org/apache/taglibs/string StringTagSupport.java
Log:
Removed the unnecessary initAttributes from inside.
This makes initAttributes unnecessary and now that I understand things
[Thanks Shawn/Hans] the initAttribute methods should be killable in
all subclasses
Revision Changes Path
1.2 +9 -4 jakarta-taglibs/string/src/org/apache/taglibs/string/StringTagSupport.java
Index: StringTagSupport.java
===================================================================
RCS file: /home/cvs/jakarta-taglibs/string/src/org/apache/taglibs/string/StringTagSupport.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- StringTagSupport.java 21 Apr 2002 04:27:42 -0000 1.1
+++ StringTagSupport.java 14 Oct 2002 02:47:23 -0000 1.2
@@ -138,7 +138,12 @@
JspWriter writer = pageContext.getOut();
try {
writer.print(text);
- initAttributes();
+// This call is bad, as the container does not need to actually
+// reset the attributes if they've not been changed, such as a
+// tag within a loop.
+// I had mistakenly believed that I had to re-initialise attributes
+// after their setup.
+// initAttributes();
} catch (IOException e) {
throw new JspException(e.toString());
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>