You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/01 03:37:23 UTC

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #488: Update rand, proc-macro and zstd dependencies

jorgecarleitao commented on a change in pull request #488:
URL: https://github.com/apache/arrow-rs/pull/488#discussion_r661946898



##########
File path: arrow/Cargo.toml
##########
@@ -40,7 +40,10 @@ serde = { version = "1.0", features = ["rc"] }
 serde_derive = "1.0"
 serde_json = { version = "1.0", features = ["preserve_order"] }
 indexmap = "1.6"
-rand = "0.7"
+rand = { version = "0.8", default-features = false }
+# getrandom is a dependency of rand, not (directly) of arrow
+# need to specify `js` feature to build on wasm
+getrandom = { version = "0.2", features = ["js"] }

Review comment:
       we may be able to achieve the same using `rand` with feature `getrandom/js`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org