You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Alexander af Trolle (JIRA)" <ji...@apache.org> on 2018/02/09 14:37:00 UTC
[jira] [Issue Comment Deleted] (GEODE-4601) Refactor TcrMessage -
resolve accessor encapsulation
[ https://issues.apache.org/jira/browse/GEODE-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander af Trolle updated GEODE-4601:
---------------------------------------
Comment: was deleted
(was: Hello, My name is Alexander af Trolle.
We are a couple of computer master student taking a university course which require a group of students to take on one or many issues with refactoring of open source projects.
I'm wondering if we can we take on this issue ticket and get assigned to it?
Your sincerely Alexander. )
> Refactor TcrMessage - resolve accessor encapsulation
> ----------------------------------------------------
>
> Key: GEODE-4601
> URL: https://issues.apache.org/jira/browse/GEODE-4601
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Addison
> Priority: Major
>
> {{TcrMessage}} has accessor {{setMessageType()}} which should be removed from the base class. It is used only on reply messages, _not_ request messages.
> Here are some steps we can take:
> # Move it into the {{TcrMessageReply}} class.
> # Remove the accessor entirely by altering internal APIs, e.g. {{TcrMessageHelper::readChunkPartHeader()}}, to return a message object rather than taking a reference to a message and then modifying the type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)