You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/04 18:05:00 UTC
[GitHub] [druid] vtlim opened a new pull request, #12394: Document data format and example for featureSpec
vtlim opened a new pull request, #12394:
URL: https://github.com/apache/druid/pull/12394
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #12394: Document data format and example for featureSpec
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #12394:
URL: https://github.com/apache/druid/pull/12394#discussion_r844136357
##########
docs/ingestion/data-formats.md:
##########
@@ -584,7 +584,7 @@ For example:
### FlattenSpec
-The `flattenSpec` bridges the gap between potentially nested input data (such as JSON, Avro, etc) and Druid's flat data model. It is an object within the `inputFormat` object.
+The `flattenSpec` object bridges the gap between potentially nested input data (such as JSON, Avro, etc) and Druid's flat data model. It is an object within the `inputFormat` object.
Review Comment:
```suggestion
The `flattenSpec` object bridges the gap between potentially nested input data, such as JSON or Avro, and Druid's flat data model. It is an object within the `inputFormat` object.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a diff in pull request #12394: Document data format and example for featureSpec
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on code in PR #12394:
URL: https://github.com/apache/druid/pull/12394#discussion_r843374844
##########
docs/ingestion/data-formats.md:
##########
@@ -584,7 +584,7 @@ For example:
### FlattenSpec
-The `flattenSpec` bridges the gap between potentially nested input data (such as JSON, Avro, etc) and Druid's flat data model. It is an object within the `inputFormat` object.
+The `flattenSpec` object bridges the gap between potentially nested input data (such as JSON, Avro, etc) and Druid's flat data model. It is an object within the `inputFormat` object.
Review Comment:
nit: avoid parens if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #12394: Document data format and example for featureSpec
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #12394:
URL: https://github.com/apache/druid/pull/12394#discussion_r844135335
##########
docs/ingestion/data-formats.md:
##########
@@ -89,7 +89,7 @@ Configure the JSON `inputFormat` to load JSON data as follows:
|-------|------|-------------|----------|
| type | String | Set value to `json`. | yes |
| flattenSpec | JSON Object | Specifies flattening configuration for nested JSON data. See [`flattenSpec`](#flattenspec) for more info. | no |
-| featureSpec | JSON Object | [JSON parser features](https://github.com/FasterXML/jackson-core/wiki/JsonParser-Features) supported by Jackson library. Those features will be applied when parsing the input JSON data. | no |
+| featureSpec | JSON Object | [JSON parser features](https://github.com/FasterXML/jackson-core/wiki/JsonParser-Features) supported by Jackson, a JSON processor for Java. The features control parsing of the input JSON data. Map the feature name to a Boolean value of whether the feature is enabled. For example: `"featureSpec": {"ALLOW_SINGLE_QUOTES": true, "ALLOW_UNQUOTED_FIELD_NAMES": true}` | no |
Review Comment:
The description links to the Jackson parser doc, where the features are listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a diff in pull request #12394: Document data format and example for featureSpec
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on code in PR #12394:
URL: https://github.com/apache/druid/pull/12394#discussion_r843372728
##########
docs/ingestion/data-formats.md:
##########
@@ -74,8 +74,8 @@ parsing data is less efficient than writing a native Java parser or using an ext
## Input format
-> The Input Format is a new way to specify the data format of your input data which was introduced in 0.17.0.
-Unfortunately, the Input Format doesn't support all data formats or ingestion methods supported by Druid yet.
+> The `inputFormat` field is a new way to specify the data format of your input data which was introduced in 0.17.0.
+Unfortunately, `inputFormat` doesn't support all data formats or ingestion methods supported by Druid yet.
Review Comment:
```suggestion
> `inputFormat` doesn't support all data formats or ingestion methods supported by Druid yet.
```
Unfortunately is unnecessary.
##########
docs/ingestion/data-formats.md:
##########
@@ -89,7 +89,7 @@ Configure the JSON `inputFormat` to load JSON data as follows:
|-------|------|-------------|----------|
| type | String | Set value to `json`. | yes |
| flattenSpec | JSON Object | Specifies flattening configuration for nested JSON data. See [`flattenSpec`](#flattenspec) for more info. | no |
-| featureSpec | JSON Object | [JSON parser features](https://github.com/FasterXML/jackson-core/wiki/JsonParser-Features) supported by Jackson library. Those features will be applied when parsing the input JSON data. | no |
+| featureSpec | JSON Object | [JSON parser features](https://github.com/FasterXML/jackson-core/wiki/JsonParser-Features) supported by Jackson, a JSON processor for Java. The features control parsing of the input JSON data. Map the feature name to a Boolean value of whether the feature is enabled. For example: `"featureSpec": {"ALLOW_SINGLE_QUOTES": true, "ALLOW_UNQUOTED_FIELD_NAMES": true}` | no |
Review Comment:
```suggestion
| featureSpec | JSON Object | [JSON parser features](https://github.com/FasterXML/jackson-core/wiki/JsonParser-Features) supported by Jackson, a JSON processor for Java. The features control parsing of the input JSON data. To enable a feature, map the feature name to a Boolean value of "true". For example: `"featureSpec": {"ALLOW_SINGLE_QUOTES": true, "ALLOW_UNQUOTED_FIELD_NAMES": true}` | no |
```
If a feature is not listed as "true", does it default to "false"? Maybe not for this PR, but do we need a list of features?
##########
docs/ingestion/data-formats.md:
##########
@@ -74,8 +74,8 @@ parsing data is less efficient than writing a native Java parser or using an ext
## Input format
-> The Input Format is a new way to specify the data format of your input data which was introduced in 0.17.0.
-Unfortunately, the Input Format doesn't support all data formats or ingestion methods supported by Druid yet.
+> The `inputFormat` field is a new way to specify the data format of your input data which was introduced in 0.17.0.
Review Comment:
```suggestion
You can use the `inputFormat` field to specify the data format for your input data.
```
We're on 0.22.1. It's not new anymore. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith merged pull request #12394: Document data format and example for featureSpec
Posted by GitBox <gi...@apache.org>.
techdocsmith merged PR #12394:
URL: https://github.com/apache/druid/pull/12394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org