You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/23 02:05:27 UTC
[GitHub] [doris] morningman commented on a diff in pull request #13497: [Bug](policy) Add readlock for show policy
morningman commented on code in PR #13497:
URL: https://github.com/apache/doris/pull/13497#discussion_r1002617193
##########
fe/fe-core/src/main/java/org/apache/doris/policy/PolicyMgr.java:
##########
@@ -186,16 +200,25 @@ private boolean existPolicy(DropPolicyLog checkedDropPolicy) {
* @return Policy in typeToPolicyMap
*/
public Policy getPolicy(Policy checkedPolicy) {
- List<Policy> policies = getPoliciesByType(checkedPolicy.getType());
- for (Policy policy : policies) {
- if (policy.matchPolicy(checkedPolicy)) {
- return policy;
+ readLock();
+ try {
+ List<Policy> policies = getPoliciesByType(checkedPolicy.getType());
+ for (Policy policy : policies) {
+ if (policy.matchPolicy(checkedPolicy)) {
+ return policy;
+ }
}
+ return null;
+ } finally {
+ readUnlock();
}
- return null;
}
- public List<Policy> getPoliciesByType(PolicyTypeEnum policyType) {
+ public List<Policy> getCopiedPoliciesByType(PolicyTypeEnum policyType) {
Review Comment:
This should also be wrapped with readlock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org