You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/24 07:44:32 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request #2908: signal: set SIGRTMIN to SIGUSR1 because signo 0 don't catch.
Donny9 opened a new pull request #2908:
URL: https://github.com/apache/incubator-nuttx/pull/2908
## Summary
we can catch signal SIGRTMIN by this path.
## Impact
## Testing
daily test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2908: signal: set SIGRTMIN to SIGUSR1 because signo 0 don't catch.
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #2908:
URL: https://github.com/apache/incubator-nuttx/pull/2908#discussion_r581862580
##########
File path: include/signal.h
##########
@@ -43,7 +43,7 @@
#define NULL_SIGNAL_SET ((sigset_t)0x00000000)
#define ALL_SIGNAL_SET ((sigset_t)0xffffffff)
-#define MIN_SIGNO 0
+#define MIN_SIGNO 1
#define MAX_SIGNO 31
Review comment:
The title says SIGRTMIN to SIGUSR1
But isn't this the bit position? Not the mapping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2908: signal: change SIGRTMIN to 1 because signo 0 don't catch.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2908:
URL: https://github.com/apache/incubator-nuttx/pull/2908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #2908: signal: set SIGRTMIN to SIGUSR1 because signo 0 don't catch.
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #2908:
URL: https://github.com/apache/incubator-nuttx/pull/2908#discussion_r581972780
##########
File path: include/signal.h
##########
@@ -43,7 +43,7 @@
#define NULL_SIGNAL_SET ((sigset_t)0x00000000)
#define ALL_SIGNAL_SET ((sigset_t)0xffffffff)
-#define MIN_SIGNO 0
+#define MIN_SIGNO 1
#define MAX_SIGNO 31
Review comment:
>
>
> The title says SIGRTMIN to SIGUSR1
>
> But isn't this the bit position? Not the mapping?
I misdescribed it, i will modify this title. sorry~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org