You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "jsedding (via GitHub)" <gi...@apache.org> on 2025/08/07 14:58:55 UTC

[PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

jsedding opened a new pull request, #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260880447


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -245,23 +248,22 @@ private void createNextFile(int suffix) throws IOException {
         }
 
         private int parseCurrentSuffix() {
-            String name = AzureUtilities.getName(currentBlob);

Review Comment:
   the issue should be to change this line with:
   ```
   String name = currentBlob.getBlobName();
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#issuecomment-3165081300

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2436) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [72.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2436&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2436)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding closed pull request #2436: OAK-11847 - AzureJournalFile fails to rotate journal
URL: https://github.com/apache/jackrabbit-oak/pull/2436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260603731


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -33,16 +33,19 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
-import java.util.*;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
 import java.util.stream.Collectors;
 
 public class AzureJournalFile implements JournalFile {
 
     private static final Logger log = LoggerFactory.getLogger(AzureJournalFile.class);
 
-    private static final int JOURNAL_LINE_LIMIT = Integer.getInteger("org.apache.jackrabbit.oak.segment.azure.journal.lines", 40_000);
+    static final int JOURNAL_LINE_LIMIT = Integer.getInteger("org.apache.jackrabbit.oak.segment.azure.journal.lines", 40_000);

Review Comment:
   this should use SystemPropertyProvider...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#issuecomment-3167846421

   Closing as #2438 was merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#issuecomment-3165120748

   Created this https://github.com/apache/jackrabbit-oak/pull/2438 with the fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#issuecomment-3165010339

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2436) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [72.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2436&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2436)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260894944


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -245,23 +248,22 @@ private void createNextFile(int suffix) throws IOException {
         }
 
         private int parseCurrentSuffix() {
-            String name = AzureUtilities.getName(currentBlob);

Review Comment:
   this is because the `journalNamePrefix` = `rootPrefix + "/journal.log"` 
   
   and the result of `AzureUtilities.getName(currentBlob);` = `journal.log` or `journal.log.001`
   
   however is we change it to `currentBlob.getBlobName();` = `rootPrefix + "/journal.log"` or `rootPrefix + "/journal.log.001"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260645087


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java:
##########
@@ -89,7 +96,7 @@ public boolean segmentFilesExist() {
 
     @Override
     public JournalFile getJournalFile() {
-        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController);
+        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController, journalLineLimit);

Review Comment:
   this is set here https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java#L66



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260820467


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java:
##########
@@ -89,7 +96,7 @@ public boolean segmentFilesExist() {
 
     @Override
     public JournalFile getJournalFile() {
-        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController);
+        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController, journalLineLimit);

Review Comment:
   the logic for setting the `journalLineLimit` has not changed.
   
   The problem indeed is because of the `rootPrefix + "/journal.log"` in the constructor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260665847


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -33,16 +33,19 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
-import java.util.*;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
 import java.util.stream.Collectors;
 
 public class AzureJournalFile implements JournalFile {
 
     private static final Logger log = LoggerFactory.getLogger(AzureJournalFile.class);
 
-    private static final int JOURNAL_LINE_LIMIT = Integer.getInteger("org.apache.jackrabbit.oak.segment.azure.journal.lines", 40_000);
+    static final int JOURNAL_LINE_LIMIT = Integer.getInteger("org.apache.jackrabbit.oak.segment.azure.journal.lines", 40_000);

Review Comment:
   agreed, but I would say that's for a different JIRA ticket.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260635685


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java:
##########
@@ -89,7 +96,7 @@ public boolean segmentFilesExist() {
 
     @Override
     public JournalFile getJournalFile() {
-        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController);
+        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController, journalLineLimit);

Review Comment:
   `journalLineLimit` is already available in  `AzureJournalFile`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#issuecomment-3164558832

   # Commit-Check ✔️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260672887


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java:
##########
@@ -89,7 +96,7 @@ public boolean segmentFilesExist() {
 
     @Override
     public JournalFile getJournalFile() {
-        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController);
+        return new AzureJournalFile(readBlobContainerClient, writeBlobContainerClient, rootPrefix + "/journal.log", writeAccessController, journalLineLimit);

Review Comment:
   I wanted to use the way `AzurePersistence` constructs `AzureJournalFile`, because the bug was introduced by changing the arguments of the `AzureJournalFile` constructor.
   
   However, by doing that, I needed a way to feed the `journalLineLimit` through `AzurePersistence`. I'm more than happy if you see a better way to achieve this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260840959


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -245,23 +248,22 @@ private void createNextFile(int suffix) throws IOException {
         }
 
         private int parseCurrentSuffix() {
-            String name = AzureUtilities.getName(currentBlob);

Review Comment:
   the issue should be fixed by just changing this line to 
   ```
   String name = currentBlob.getBlobName();
   ````



##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -245,23 +248,22 @@ private void createNextFile(int suffix) throws IOException {
         }
 
         private int parseCurrentSuffix() {
-            String name = AzureUtilities.getName(currentBlob);

Review Comment:
   the issue should be fixed by just changing this line to 
   ```
   String name = currentBlob.getBlobName();
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11847 - AzureJournalFile fails to rotate journal [jackrabbit-oak]

Posted by "ierandra (via GitHub)" <gi...@apache.org>.
ierandra commented on code in PR #2436:
URL: https://github.com/apache/jackrabbit-oak/pull/2436#discussion_r2260880447


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:
##########
@@ -245,23 +248,22 @@ private void createNextFile(int suffix) throws IOException {
         }
 
         private int parseCurrentSuffix() {
-            String name = AzureUtilities.getName(currentBlob);

Review Comment:
   the issue should be fixed to change this line with:
   ```
   String name = currentBlob.getBlobName();
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org