You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/01/21 12:28:06 UTC
[GitHub] [incubator-inlong] dockerzhang opened a new pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
dockerzhang opened a new pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fixes #2271
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
Posted by GitBox <gi...@apache.org>.
luchunliang commented on pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273#issuecomment-1019191722
Will TDMsg format be normal Inlong format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang edited a comment on pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
Posted by GitBox <gi...@apache.org>.
luchunliang edited a comment on pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273#issuecomment-1019191722
Will TDMsg format be official Inlong format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273#issuecomment-1019400203
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2273](https://codecov.io/gh/apache/incubator-inlong/pull/2273?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30f1d85) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/2557dcb56e4060ceda307fcfc66ad15a47ad115b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2557dcb) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/2273/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/2273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2273 +/- ##
=========================================
Coverage 12.54% 12.54%
Complexity 1217 1217
=========================================
Files 420 420
Lines 36235 36235
Branches 5674 5674
=========================================
Hits 4545 4545
Misses 30881 30881
Partials 809 809
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2273?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2273?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2557dcb...30f1d85](https://codecov.io/gh/apache/incubator-inlong/pull/2273?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang edited a comment on pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
Posted by GitBox <gi...@apache.org>.
luchunliang edited a comment on pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273#issuecomment-1019191722
Will TDMsg format be formal Inlong format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273#issuecomment-1019392953
@luchunliang Yes, the name of TDMsg is confused for developers. We rename it as InLongMsg, and will add more description for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2273: [INLONG-2271] move TDMsg to InLongMsg
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2273:
URL: https://github.com/apache/incubator-inlong/pull/2273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org