You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/30 04:05:11 UTC

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5985: Add t3c If-Modified-Since Support

rawlinp commented on a change in pull request #5985:
URL: https://github.com/apache/trafficcontrol/pull/5985#discussion_r661114264



##########
File path: traffic_ops/toclientlib/toclientlib.go
##########
@@ -808,6 +809,7 @@ type ReqInf struct {
 	CacheHitStatus CacheHitStatus
 	RemoteAddr     net.Addr
 	StatusCode     int
+	Headers        http.Header

Review comment:
       Should these be called `ResponseHeaders` as opposed to just `Headers`? I think these could be confused as request headers, since the type name is short for "request info".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org