You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/05/24 08:56:49 UTC
[GitHub] [iceberg] kbendick opened a new issue #2628: Possible NPE in BaseMetastoreTableOperations#checkCommitStatus for Nessie tables.
kbendick opened a new issue #2628:
URL: https://github.com/apache/iceberg/issues/2628
`BaseMetastoreTableOperations#checkCommitStatus` will either throw an NPE when called on a table backed by the Nessie Catalog, or will log the table name as `null` even though it is known.
`checkCommitStatus` uses `BaseMetastoreTableOperations#tableName` for logging, which is not declared as abstract and by default returns `null`.
`GlueTableOperations` and `HiveTableOperations` both override this method, and so won't throw an NPE or use `null` as the table name when logging if `checkCommitStatus` is called
However, `NessiteTableOperations` does not override `tableName`, and thus will either throw or log `null` for the table name.
If we make `BaseMetastoreTableOperations#tableName` into an abstract method, then this error would be caught at compile time.
Currently, because the logger uses `tableName()` as a string format argument, I believe that currently the table name will simply be logged as `null` (which will still be confusing to users and should be fixed).
In the event of a refactor, an NPE is very likely as there are no compile time checks that this method is properly overridden, unless we mark it as `abstract`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr closed issue #2628: Possible malformed log or NPE in BaseMetastoreTableOperations#checkCommitStatus for Nessie tables.
Posted by GitBox <gi...@apache.org>.
rymurr closed issue #2628:
URL: https://github.com/apache/iceberg/issues/2628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #2628: Possible NPE in BaseMetastoreTableOperations#checkCommitStatus for Nessie tables.
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #2628:
URL: https://github.com/apache/iceberg/issues/2628#issuecomment-846939908
I have a PR for this, which I will push in the morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org