You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/03/24 15:17:02 UTC
[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3884: Fix write entry failed in without writing journal case
hangc0276 opened a new pull request, #3884:
URL: https://github.com/apache/bookkeeper/pull/3884
### Motivation
https://github.com/apache/bookkeeper/pull/3837 introduced group flush add responses triggered by journal sync. However, if we skip writing journals, the add responses won't be flushed to the netty channel and the client will receive write entries timeout.
### Changes
- Flush the add responses when skipping writing journals
- Add tests to cover V2 protocol and skip writing journal cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3884: Fix write entry failed in without writing journal case
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3884:
URL: https://github.com/apache/bookkeeper/pull/3884#issuecomment-1482981686
@merlimat @eolivelli @zymap @horizonzy Please help take a look at this fix, and it is a blocker for BookKeeper 4.16.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3884: Fix write entry failed in without writing journal case
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3884:
URL: https://github.com/apache/bookkeeper/pull/3884#issuecomment-1482982517
> Great catch
>
> It's weird that no test failed!
@eolivelli I found no tests covered this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3884: Fix write entry failed in without writing journal case
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #3884:
URL: https://github.com/apache/bookkeeper/pull/3884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org