[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8619: Implement the trace function and add tracepoints for the startup process

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8619:
URL: https://github.com/apache/nuttx/pull/8619#discussion_r1122027368


##########
include/nuttx/trace.h:
##########
@@ -0,0 +1,154 @@
+/****************************************************************************
+ * include/nuttx/trace.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_TRACE_H
+#define __INCLUDE_NUTTX_TRACE_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/sched_note.h>
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#if defined(CONFIG_SCHED_INSTRUMENTATION_DUMP) && defined(CONFIG_TRACE)

Review Comment:
   #ifdef CONFIG_TRACE



##########
Kconfig:
##########
@@ -2006,6 +2006,65 @@ config FRAME_POINTER
 
 endmenu # Debug Options
 
+menuconfig  TRACE
+	bool "Enable tracepoints"
+	default n
+	depends on SCHED_INSTRUMENTATION_DUMP && DRIVERS_NOTE

Review Comment:
   remove DRIVERS_NOTE, arch can provide a brand new implementation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org