You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/12/20 17:24:11 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #955: HBASE-23597 Give high priority for meta assign procedure and ServerCr…

saintstack commented on a change in pull request #955: HBASE-23597 Give high priority for meta assign procedure and ServerCr…
URL: https://github.com/apache/hbase/pull/955#discussion_r360444216
 
 

 ##########
 File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/AbstractProcedureScheduler.java
 ##########
 @@ -174,7 +188,7 @@ public Procedure poll(final long nanos) {
           return null;
         }
       }
-      final Procedure pollResult = dequeue();
+      final Procedure pollResult = dequeue(highPriority);
 
       pollCalls++;
       nullPollCalls += (pollResult == null) ? 1 : 0;
 
 Review comment:
   It is a pity we have to add the boolean priority flag as it makes this queue Interface no longer look like the usual queue Interface (they don't usually take a flag like this).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services