You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2023/07/24 08:55:51 UTC

[GitHub] [james-project] vttranlina opened a new pull request, #1654: Upgrade dependency cassandra 3 -> 4

vttranlina opened a new pull request, #1654:
URL: https://github.com/apache/james-project/pull/1654

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] vttranlina commented on a diff in pull request #1654: Upgrade dependency cassandra 3 -> 4

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1654:
URL: https://github.com/apache/james-project/pull/1654#discussion_r1272935277


##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -168,7 +168,7 @@ public void close() {
             new ImageFromDockerfile(imageName,doNotDeleteImageAfterUsage)
                 .withDockerfileFromBuilder(builder ->
                     additionalSteps.applyStep(builder
-                        .from("cassandra:3.11.15")
+                        .from("cassandra:4.0")

Review Comment:
   4.1 is GA Version, 4.0 is Stable version,
   is it ok with 4.1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a diff in pull request #1654: Upgrade dependency cassandra 3 -> 4

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1654:
URL: https://github.com/apache/james-project/pull/1654#discussion_r1272364356


##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -168,7 +168,7 @@ public void close() {
             new ImageFromDockerfile(imageName,doNotDeleteImageAfterUsage)
                 .withDockerfileFromBuilder(builder ->
                     additionalSteps.applyStep(builder
-                        .from("cassandra:3.11.15")
+                        .from("cassandra:4.0")

Review Comment:
   4.1.latest please



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] vttranlina commented on pull request #1654: Upgrade dependency cassandra 3 -> 4

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1654:
URL: https://github.com/apache/james-project/pull/1654#issuecomment-1649007818

   CI fail
   ```
   Existing failures - 10
   (?) – org.apache.james.jmap.cassandra.access.CassandraAccessTokenRepositoryTest
   <1s
   (?) – org.apache.james.jmap.cassandra.change.CassandraEmailChangeRepositoryTest
   ...
   ```
   I tested it on my local, and it passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael merged pull request #1654: Upgrade dependency cassandra 3 -> 4

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1654:
URL: https://github.com/apache/james-project/pull/1654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael commented on pull request #1654: Upgrade dependency cassandra 3 -> 4

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1654:
URL: https://github.com/apache/james-project/pull/1654#issuecomment-1649116419

   I see in the CI logs => `Could not initialize class org.apache.james.backends.cassandra.DockerCassandraSingleton`
   
   I think unrelated, I will restart your PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a diff in pull request #1654: Upgrade dependency cassandra 3 -> 4

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1654:
URL: https://github.com/apache/james-project/pull/1654#discussion_r1273054844


##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -168,7 +168,7 @@ public void close() {
             new ImageFromDockerfile(imageName,doNotDeleteImageAfterUsage)
                 .withDockerfileFromBuilder(builder ->
                     additionalSteps.applyStep(builder
-                        .from("cassandra:3.11.15")
+                        .from("cassandra:4.0")

Review Comment:
   Yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org