You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by shanthoosh <gi...@git.apache.org> on 2017/08/14 22:12:58 UTC

[GitHub] samza pull request #270: SAMZA-1390: Update SamzaMonitorService to spawn dea...

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/270

    SAMZA-1390: Update SamzaMonitorService to spawn deamon threads

    Observed in LinkedIn production setup that samza-rest jvm process doesn’t stop after main
    thread death(due to jetty server failures) since non-deamon threads spawned for
    `SamzaMonitorService` are alive.
    
    This affects samza-rest jvm process lifecycle management. To fix this, plugging
    in ThreadFactory which sets Thread name format & marks them as daemon.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza make_samza_rest_non_daemon

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #270
    
----
commit e283ad446546711287bc0c5e83f7a8cf0856892f
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Date:   2017-08-14T21:41:46Z

    SAMZA-1390: Update SamzaMonitorService to spawn deamon threads
    
    Observed in LI production that samza-rest jvm process doesn’t stop after main
    thread death(due to jetty server failures) since non-deamon threads spawned for
    `SamzaMonitorService` are alive.
    
    This affects samza-rest jvm process lifecycle management. To fix this, plugging
    in ThreadFactory which sets Thread name format & marks them as daemon.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] samza pull request #270: SAMZA-1390: Update SamzaMonitorService to spawn dea...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---