You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/13 01:45:19 UTC
[GitHub] [spark] gatorsmile opened a new pull request #27896: [SPARK-28093]
Remove migration guide of TRIM changes
gatorsmile opened a new pull request #27896: [SPARK-28093] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896
### What changes were proposed in this pull request?
Since we reverted the original change in https://github.com/apache/spark/pull/27540, this PR is to remove the corresponding migration guide made in the commit https://github.com/apache/spark/pull/24948
### Why are the changes needed?
N/A
### Does this PR introduce any user-facing change?
N/A
### How was this patch tested?
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598512807
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119736/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598508658
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24465/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598521603
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598508651
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598510284
I will merge when the documentation build job pass (https://github.com/apache/spark/runs/504708388)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27896: [SPARK-28093][FOLLOW-UP]
Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598512738
**[Test build #119736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119736/testReport)** for PR 27896 at commit [`ad72c75`](https://github.com/apache/spark/commit/ad72c75475799425bcd5ade2dd6dd9ccdd077ce4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598533743
+1, late LGTM. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598512803
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598508651
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27896: [SPARK-28093][FOLLOW-UP]
Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598529698
late LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598512803
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598508500
cc @cloud-fan @maropu @dongjoon-hyun @Ngone51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598508658
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24465/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27896: [SPARK-28093][FOLLOW-UP]
Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598510156
**[Test build #119736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119736/testReport)** for PR 27896 at commit [`ad72c75`](https://github.com/apache/spark/commit/ad72c75475799425bcd5ade2dd6dd9ccdd077ce4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598510156
**[Test build #119736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119736/testReport)** for PR 27896 at commit [`ad72c75`](https://github.com/apache/spark/commit/ad72c75475799425bcd5ade2dd6dd9ccdd077ce4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27896:
[SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27896: [SPARK-28093][FOLLOW-UP] Remove migration guide of TRIM changes
URL: https://github.com/apache/spark/pull/27896#issuecomment-598512807
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119736/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org