You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/25 00:49:41 UTC
[GitHub] [shardingsphere] totalo opened a new pull request #9810: change the sqlState len
totalo opened a new pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810
Fixes #8179 .
Changes proposed in this pull request:
- change the sqlState len
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
totalo commented on pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810#issuecomment-806474092
> @totalo The ci still failed. Please check the test cases.
done , thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810#discussion_r601025566
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -27,35 +27,35 @@
@Getter
public enum CommonErrorCode implements SQLErrorCode {
- CIRCUIT_BREAK_MODE(10000, "C10000", "Circuit break mode is ON."),
+ CIRCUIT_BREAK_MODE(1000, "C1000", "Circuit break mode is ON."),
- SHARDING_TABLE_RULES_NOT_EXISTED(11001, "C11001", "Sharding table rule %s is not exist."),
+ SHARDING_TABLE_RULES_NOT_EXISTED(1101, "C1101", "Sharding table rule %s is not exist."),
- TABLES_IN_USED(11002, "C11002", "Can not drop rule, tables %s in the rule are still in used."),
+ TABLES_IN_USED(1102, "C1102", "Can not drop rule, tables %s in the rule are still in used."),
- RESOURCE_IN_USED(11003, "C11003", "Can not drop resources, resources %s in the rule are still in used."),
+ RESOURCE_IN_USED(1103, "C1103", "Can not drop resources, resources %s in the rule are still in used."),
- RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ RESOURCE_NOT_EXIST(1104, "C1104", "Can not drop resources, resources %s do not exist."),
- REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule does not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(1105, "C1105", "Replica query rule does not exist."),
- REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(11006, "C11006", "Data sources %s in replica query rule do not exist."),
+ REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(1106, "C1106", "Data sources %s in replica query rule do not exist."),
- ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(11007, "C11007", "Can not add replica query rule, data sources %s in replica query rule already exists."),
+ ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(1107, "C1107", "Can not add replica query rule, data sources %s in replica query rule already exists."),
- REPLICA_QUERY_RULE_EXIST(11008, "C11008", "Replica query rule already exists."),
+ REPLICA_QUERY_RULE_EXIST(1108, "C1108", "Replica query rule already exists."),
- SHARDING_RULE_NOT_EXIST(11009, "C11009", "Sharding rule does not exist."),
+ SHARDING_RULE_NOT_EXIST(1109, "C1109", "Sharding rule does not exist."),
- SHARDING_TABLE_RULE_EXIST(11010, "C11010", "Sharding table rules: [%s] already exists."),
+ SHARDING_TABLE_RULE_EXIST(1110, "C1110", "Sharding table rules: [%s] already exists."),
- SCALING_JOB_NOT_EXIST(12001, "C12001", "Scaling job %s does not exist."),
+ SCALING_JOB_NOT_EXIST(1201, "C1201", "Scaling job %s does not exist."),
- SCALING_OPERATE_FAILED(12009, "C12009", "Scaling Operate Failed: [%s]"),
+ SCALING_OPERATE_FAILED(12009, "C1209", "Scaling Operate Failed: [%s]"),
Review comment:
Do you mean 1209?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810#discussion_r601040395
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -27,35 +27,35 @@
@Getter
public enum CommonErrorCode implements SQLErrorCode {
- CIRCUIT_BREAK_MODE(10000, "C10000", "Circuit break mode is ON."),
+ CIRCUIT_BREAK_MODE(1000, "C1000", "Circuit break mode is ON."),
- SHARDING_TABLE_RULES_NOT_EXISTED(11001, "C11001", "Sharding table rule %s is not exist."),
+ SHARDING_TABLE_RULES_NOT_EXISTED(1101, "C1101", "Sharding table rule %s is not exist."),
- TABLES_IN_USED(11002, "C11002", "Can not drop rule, tables %s in the rule are still in used."),
+ TABLES_IN_USED(1102, "C1102", "Can not drop rule, tables %s in the rule are still in used."),
- RESOURCE_IN_USED(11003, "C11003", "Can not drop resources, resources %s in the rule are still in used."),
+ RESOURCE_IN_USED(1103, "C1103", "Can not drop resources, resources %s in the rule are still in used."),
- RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ RESOURCE_NOT_EXIST(1104, "C1104", "Can not drop resources, resources %s do not exist."),
- REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule does not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(1105, "C1105", "Replica query rule does not exist."),
- REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(11006, "C11006", "Data sources %s in replica query rule do not exist."),
+ REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(1106, "C1106", "Data sources %s in replica query rule do not exist."),
- ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(11007, "C11007", "Can not add replica query rule, data sources %s in replica query rule already exists."),
+ ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(1107, "C1107", "Can not add replica query rule, data sources %s in replica query rule already exists."),
- REPLICA_QUERY_RULE_EXIST(11008, "C11008", "Replica query rule already exists."),
+ REPLICA_QUERY_RULE_EXIST(1108, "C1108", "Replica query rule already exists."),
- SHARDING_RULE_NOT_EXIST(11009, "C11009", "Sharding rule does not exist."),
+ SHARDING_RULE_NOT_EXIST(1109, "C1109", "Sharding rule does not exist."),
- SHARDING_TABLE_RULE_EXIST(11010, "C11010", "Sharding table rules: [%s] already exists."),
+ SHARDING_TABLE_RULE_EXIST(1110, "C1110", "Sharding table rules: [%s] already exists."),
- SCALING_JOB_NOT_EXIST(12001, "C12001", "Scaling job %s does not exist."),
+ SCALING_JOB_NOT_EXIST(1201, "C1201", "Scaling job %s does not exist."),
- SCALING_OPERATE_FAILED(12009, "C12009", "Scaling Operate Failed: [%s]"),
+ SCALING_OPERATE_FAILED(12009, "C1209", "Scaling Operate Failed: [%s]"),
Review comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810#discussion_r601025566
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -27,35 +27,35 @@
@Getter
public enum CommonErrorCode implements SQLErrorCode {
- CIRCUIT_BREAK_MODE(10000, "C10000", "Circuit break mode is ON."),
+ CIRCUIT_BREAK_MODE(1000, "C1000", "Circuit break mode is ON."),
- SHARDING_TABLE_RULES_NOT_EXISTED(11001, "C11001", "Sharding table rule %s is not exist."),
+ SHARDING_TABLE_RULES_NOT_EXISTED(1101, "C1101", "Sharding table rule %s is not exist."),
- TABLES_IN_USED(11002, "C11002", "Can not drop rule, tables %s in the rule are still in used."),
+ TABLES_IN_USED(1102, "C1102", "Can not drop rule, tables %s in the rule are still in used."),
- RESOURCE_IN_USED(11003, "C11003", "Can not drop resources, resources %s in the rule are still in used."),
+ RESOURCE_IN_USED(1103, "C1103", "Can not drop resources, resources %s in the rule are still in used."),
- RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ RESOURCE_NOT_EXIST(1104, "C1104", "Can not drop resources, resources %s do not exist."),
- REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule does not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(1105, "C1105", "Replica query rule does not exist."),
- REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(11006, "C11006", "Data sources %s in replica query rule do not exist."),
+ REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(1106, "C1106", "Data sources %s in replica query rule do not exist."),
- ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(11007, "C11007", "Can not add replica query rule, data sources %s in replica query rule already exists."),
+ ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(1107, "C1107", "Can not add replica query rule, data sources %s in replica query rule already exists."),
- REPLICA_QUERY_RULE_EXIST(11008, "C11008", "Replica query rule already exists."),
+ REPLICA_QUERY_RULE_EXIST(1108, "C1108", "Replica query rule already exists."),
- SHARDING_RULE_NOT_EXIST(11009, "C11009", "Sharding rule does not exist."),
+ SHARDING_RULE_NOT_EXIST(1109, "C1109", "Sharding rule does not exist."),
- SHARDING_TABLE_RULE_EXIST(11010, "C11010", "Sharding table rules: [%s] already exists."),
+ SHARDING_TABLE_RULE_EXIST(1110, "C1110", "Sharding table rules: [%s] already exists."),
- SCALING_JOB_NOT_EXIST(12001, "C12001", "Scaling job %s does not exist."),
+ SCALING_JOB_NOT_EXIST(1201, "C1201", "Scaling job %s does not exist."),
- SCALING_OPERATE_FAILED(12009, "C12009", "Scaling Operate Failed: [%s]"),
+ SCALING_OPERATE_FAILED(12009, "C1209", "Scaling Operate Failed: [%s]"),
Review comment:
Maybe you want to change
`12009, "C12009" `
to
`1209, "C12009? `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810#discussion_r601025566
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -27,35 +27,35 @@
@Getter
public enum CommonErrorCode implements SQLErrorCode {
- CIRCUIT_BREAK_MODE(10000, "C10000", "Circuit break mode is ON."),
+ CIRCUIT_BREAK_MODE(1000, "C1000", "Circuit break mode is ON."),
- SHARDING_TABLE_RULES_NOT_EXISTED(11001, "C11001", "Sharding table rule %s is not exist."),
+ SHARDING_TABLE_RULES_NOT_EXISTED(1101, "C1101", "Sharding table rule %s is not exist."),
- TABLES_IN_USED(11002, "C11002", "Can not drop rule, tables %s in the rule are still in used."),
+ TABLES_IN_USED(1102, "C1102", "Can not drop rule, tables %s in the rule are still in used."),
- RESOURCE_IN_USED(11003, "C11003", "Can not drop resources, resources %s in the rule are still in used."),
+ RESOURCE_IN_USED(1103, "C1103", "Can not drop resources, resources %s in the rule are still in used."),
- RESOURCE_NOT_EXIST(11004, "C11004", "Can not drop resources, resources %s do not exist."),
+ RESOURCE_NOT_EXIST(1104, "C1104", "Can not drop resources, resources %s do not exist."),
- REPLICA_QUERY_RULE_NOT_EXIST(11005, "C11005", "Replica query rule does not exist."),
+ REPLICA_QUERY_RULE_NOT_EXIST(1105, "C1105", "Replica query rule does not exist."),
- REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(11006, "C11006", "Data sources %s in replica query rule do not exist."),
+ REPLICA_QUERY_RULE_DATA_SOURCE_NOT_EXIST(1106, "C1106", "Data sources %s in replica query rule do not exist."),
- ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(11007, "C11007", "Can not add replica query rule, data sources %s in replica query rule already exists."),
+ ADD_REPLICA_QUERY_RULE_DATA_SOURCE_EXIST(1107, "C1107", "Can not add replica query rule, data sources %s in replica query rule already exists."),
- REPLICA_QUERY_RULE_EXIST(11008, "C11008", "Replica query rule already exists."),
+ REPLICA_QUERY_RULE_EXIST(1108, "C1108", "Replica query rule already exists."),
- SHARDING_RULE_NOT_EXIST(11009, "C11009", "Sharding rule does not exist."),
+ SHARDING_RULE_NOT_EXIST(1109, "C1109", "Sharding rule does not exist."),
- SHARDING_TABLE_RULE_EXIST(11010, "C11010", "Sharding table rules: [%s] already exists."),
+ SHARDING_TABLE_RULE_EXIST(1110, "C1110", "Sharding table rules: [%s] already exists."),
- SCALING_JOB_NOT_EXIST(12001, "C12001", "Scaling job %s does not exist."),
+ SCALING_JOB_NOT_EXIST(1201, "C1201", "Scaling job %s does not exist."),
- SCALING_OPERATE_FAILED(12009, "C12009", "Scaling Operate Failed: [%s]"),
+ SCALING_OPERATE_FAILED(12009, "C1209", "Scaling Operate Failed: [%s]"),
Review comment:
Maybe you want to change
`12009, "C1209" `
to
`1209, "C1209? `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on pull request #9810: change the sqlState len
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on pull request #9810:
URL: https://github.com/apache/shardingsphere/pull/9810#issuecomment-806398719
@totalo The ci still failed. Please check the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org