[jira] [Commented] (KAFKA-649) Cleanup log4j logging

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727846#comment-13727846 ] 

Jun Rao commented on KAFKA-649:
-------------------------------

Thanks for patch v5.

50. ConsoleConsumer: There is no need to change the error to fatal since it indicates a command line error.

51. KafkaApis: Not sure if we need to make this change. If there is an error in getting metadata, the client will get an error code. Logging this in the broker may not help and can pollute the log.

52. SimpleConsumer: Just logging the message of the exception is enough. It should include the type of the exception in the message.
                
> Cleanup log4j logging
> ---------------------
>
>                 Key: KAFKA-649
>                 URL: https://issues.apache.org/jira/browse/KAFKA-649
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Assignee: Jun Rao
>            Priority: Blocker
>         Attachments: kafka-649_extra.patch, kafka-649.patch, KAFKA-649.v3.patch, KAFKA-649.v4.patch, KAFKA-649.v5.patch
>
>
> Review the logs and do the following:
> 1. Fix confusing or duplicative messages
> 2. Assess that messages are at the right level (TRACE/DEBUG/INFO/WARN/ERROR)
> It would also be nice to add a log4j logger for the request logging (i.e. the access log) and another for the controller state change log, since these really have their own use cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira