You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jiashenC (via GitHub)" <gi...@apache.org> on 2026/07/20 16:15:38 UTC
[PR] [SPARK-XXXXX][SQL] Honor persistentCatalogFirst for DDL on two-part s… [spark]
jiashenC opened a new pull request, #57381:
URL: https://github.com/apache/spark/pull/57381
…ession.<name>
The DDL / misc-command resolution path (`Analyzer.lookupTableOrView`, used by DESCRIBE TABLE, ALTER TABLE, etc.) always resolved a local temp view before the persistent relation for a two-part `session.<name>` identifier, ignoring `spark.sql.legacy.persistentCatalogFirst`. The SELECT/DML path (`RelationResolution.resolveRelation`) already honors that config for the same name shape, so the two paths diverged: the same `session.<name>` could resolve to different relations in a query vs. a DDL command.
This makes `lookupTableOrView` mirror `resolveRelation`: for a two-part `session.<name>`, resolution order follows `SQLConf.prioritizeSystemCatalog` (the inverse of `PERSISTENT_CATALOG_FIRST`). All other name shapes and the default (`prioritizeSystemCatalog = true`) keep their existing behavior.
Adds SECTION 15 to `RelationQualificationSuite`, the DDL companion to the existing SELECT-path SECTION 13.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #57381:
URL: https://github.com/apache/spark/pull/57381#discussion_r3630155855
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1317,6 +1319,19 @@ class Analyzer(
case _ => None
}
}
+ // Two-part `session.<name>`: the name can denote either a local temp view `name` or a
+ // persistent relation `name` in schema `session`. Order follows
+ // `SQLConf.prioritizeSystemCatalog` (the inverse of `PERSISTENT_CATALOG_FIRST`), matching
+ // the SELECT/DML path in `RelationResolution.resolveRelation`. Without this, DDL and misc
+ // commands (e.g. DESCRIBE TABLE, ALTER TABLE) would always resolve the temp view first and
+ // ignore `PERSISTENT_CATALOG_FIRST`, diverging from how the same name resolves in a query.
+ if (identifier.length == 2 &&
+ identifier.head.equalsIgnoreCase(CatalogManager.SESSION_NAMESPACE) &&
+ !conf.prioritizeSystemCatalog) {
+ persistentCandidate.orElse(tempViewCandidate)
+ } else {
+ tempViewCandidate.orElse(persistentCandidate)
Review Comment:
Please keep `system.session.<name>` temp-only before taking this fallback. Three-part names also reach this `else`, so a missing temp view evaluates `persistentCandidate`, unlike SELECT/DML's early return from `resolveTempView`. The new test always creates the temp view and cannot catch that miss path; please add a no-temp case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "jiashenC (via GitHub)" <gi...@apache.org>.
jiashenC commented on code in PR #57381:
URL: https://github.com/apache/spark/pull/57381#discussion_r3632622340
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1317,6 +1319,19 @@ class Analyzer(
case _ => None
}
}
+ // Two-part `session.<name>`: the name can denote either a local temp view `name` or a
+ // persistent relation `name` in schema `session`. Order follows
+ // `SQLConf.prioritizeSystemCatalog` (the inverse of `PERSISTENT_CATALOG_FIRST`), matching
+ // the SELECT/DML path in `RelationResolution.resolveRelation`. Without this, DDL and misc
+ // commands (e.g. DESCRIBE TABLE, ALTER TABLE) would always resolve the temp view first and
+ // ignore `PERSISTENT_CATALOG_FIRST`, diverging from how the same name resolves in a query.
+ if (identifier.length == 2 &&
+ identifier.head.equalsIgnoreCase(CatalogManager.SESSION_NAMESPACE) &&
+ !conf.prioritizeSystemCatalog) {
+ persistentCandidate.orElse(tempViewCandidate)
+ } else {
+ tempViewCandidate.orElse(persistentCandidate)
Review Comment:
thanks! adding logic to short circuit directly for fully qualified system name. And also add test to check the behavior for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "github-actions[bot] (via GitHub) via reviews" <re...@spark.apache.org>.
github-actions[bot] commented on PR #57381:
URL: https://github.com/apache/spark/pull/57381#issuecomment-6566171366
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "jiashenC (via GitHub)" <gi...@apache.org>.
jiashenC commented on code in PR #57381:
URL: https://github.com/apache/spark/pull/57381#discussion_r3647817982
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1317,6 +1319,20 @@ class Analyzer(
case _ => None
}
}
+ // Three-part `system.session.<name>` denotes a local temp view `name` only; it must never
+ // consult the persistent schema `session`, regardless of `PERSISTENT_CATALOG_FIRST`.
+ if (CatalogManager.isFullyQualifiedSystemSessionViewName(identifier)) {
+ tempViewCandidate
+ } else if (identifier.length == 2 &&
Review Comment:
thanks! consolidate their logics and updated the user-facing change section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "github-actions[bot] (via GitHub) via reviews" <re...@spark.apache.org>.
github-actions[bot] closed pull request #57381: [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution
URL: https://github.com/apache/spark/pull/57381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "jiashenC (via GitHub)" <gi...@apache.org>.
jiashenC commented on code in PR #57381:
URL: https://github.com/apache/spark/pull/57381#discussion_r3647817982
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1317,6 +1319,20 @@ class Analyzer(
case _ => None
}
}
+ // Three-part `system.session.<name>` denotes a local temp view `name` only; it must never
+ // consult the persistent schema `session`, regardless of `PERSISTENT_CATALOG_FIRST`.
+ if (CatalogManager.isFullyQualifiedSystemSessionViewName(identifier)) {
+ tempViewCandidate
+ } else if (identifier.length == 2 &&
Review Comment:
thanks! consolidate their logics and updated the behavior change section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58226][SQL] Honor persistentCatalogFirst for DDL on two-part name resolution [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #57381:
URL: https://github.com/apache/spark/pull/57381#discussion_r3644628701
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1317,6 +1319,20 @@ class Analyzer(
case _ => None
}
}
+ // Three-part `system.session.<name>` denotes a local temp view `name` only; it must never
+ // consult the persistent schema `session`, regardless of `PERSISTENT_CATALOG_FIRST`.
+ if (CatalogManager.isFullyQualifiedSystemSessionViewName(identifier)) {
+ tempViewCandidate
+ } else if (identifier.length == 2 &&
Review Comment:
Please centralize this candidate-order policy in `RelationResolution` and let both entry paths map the ordered candidates to their own plan types. The bug fixed by this PR came from these paths diverging; duplicating the session-name and config branches here leaves the same failure mode in place for the next policy change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org