[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7456: [AIRFLOW-6817] - Move airflow __init__.py imports to sub-packages

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #7456: [AIRFLOW-6817] - Move airflow __init__.py imports to sub-packages
URL: https://github.com/apache/airflow/pull/7456#discussion_r382907274
 
 

 ##########
 File path: tests/jobs/test_local_task_job.py
 ##########
 @@ -24,10 +24,11 @@
 import pytest
 from mock import patch
 
-from airflow import AirflowException, models, settings
+from airflow import settings
+from airflow.exceptions import AirflowException
 from airflow.executors.sequential_executor import SequentialExecutor
 from airflow.jobs import LocalTaskJob
-from airflow.models import DAG, TaskInstance as TI
+from airflow.models import DAG, DagBag, TaskInstance as TI
 
 Review comment:
   > I think what would make more sense is to have a separate models/all_models.py which would import all models and this one can be used by resetdb,
   
   I am happy to do that as I am pylinting core code :D
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services