You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/04/22 20:05:35 UTC
[jira] [Created] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Harsh J created MAPREDUCE-4188:
----------------------------------
Summary: Clean up yarn-server-web-proxy
Key: MAPREDUCE-4188
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: build
Affects Versions: trunk
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4188:
-------------------------------
Status: Patch Available (was: Open)
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259601#comment-13259601 ]
Robert Joseph Evans commented on MAPREDUCE-4188:
------------------------------------------------
Maven should be taking care of that. If not something is wrong with maven, or our pom file is not specifying all of its dependencies correctly.
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4188:
-------------------------------
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.
Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259216#comment-13259216 ]
Hadoop QA commented on MAPREDUCE-4188:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523709/0016-YARN-Server-Web-Proxy-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 493 javac compiler warnings (more than the trunk's current 492 warnings).
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2283//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2283//console
This message is automatically generated.
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259219#comment-13259219 ]
Harsh J commented on MAPREDUCE-4188:
------------------------------------
The only change here is:
{code}
--- hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
+++ hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
@@ -144,7 +144,6 @@ public class WebAppProxyServlet extends HttpServlet {
config.setLocalAddress(localAddress);
HttpMethod method = new GetMethod(uri.getEscapedURI());
- @SuppressWarnings("unchecked")
Enumeration<String> names = req.getHeaderNames();
while(names.hasMoreElements()) {
String name = names.nextElement();
{code}
And with my local JDK 1.6 (and Eclipse 3.7.x), the warning ought to reduce. I'm not sure why we need an unchecked suppressor there, as the signature for {{req.getHeaderNames()}} is typed in itself:
{{Enumeration<String> javax.servlet.http.HttpServletRequest.getHeaderNames()}}
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4188:
-------------------------------
Attachment: 0016-YARN-Server-Web-Proxy-Cleanup.patch
Minor patch that cleans up javac warnings from yarn-server-web-proxy submodule.
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259378#comment-13259378 ]
Harsh J commented on MAPREDUCE-4188:
------------------------------------
The above comment is for this message:
{{-1 javac. The applied patch generated 493 javac compiler warnings (more than the trunk's current 492 warnings).}}
[Perhaps the build machines are using an old version of the http jar that has a different signature?)
> Clean up yarn-server-web-proxy
> ------------------------------
>
> Key: MAPREDUCE-4188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira