[GitHub] [beam] lukecwik commented on a change in pull request #17094: [BEAM-14116] Catch MonitoringInfoMetricName null keys or values in the constructor

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #17094:
URL: https://github.com/apache/beam/pull/17094#discussion_r829191770



##########
File path: sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
##########
@@ -466,7 +467,8 @@ SeekableByteChannel open(GcsPath path, GoogleCloudStorageReadOptions readOptions
         MonitoringInfoConstants.Labels.RESOURCE,
         GcpResourceIdentifiers.cloudStorageBucket(path.getBucket()));
     baseLabels.put(
-        MonitoringInfoConstants.Labels.GCS_PROJECT_ID, googleCloudStorageOptions.getProjectId());
+        MonitoringInfoConstants.Labels.GCS_PROJECT_ID,
+        MoreObjects.firstNonNull(googleCloudStorageOptions.getProjectId(), ""));

Review comment:
       I'm trying to find documentation as to whether this label should be unset or whether it should be set to `""`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org