Re: [PR] fix bug #2546 [dubbo-go]

["chickenlj (via GitHub)" <gi...@apache.org>]

chickenlj commented on code in PR #2552:
URL: https://github.com/apache/dubbo-go/pull/2552#discussion_r1440012153


##########
protocol/dubbo/dubbo_invoker.go:
##########
@@ -176,7 +176,7 @@ func (di *DubboInvoker) getTimeout(ivc *invocation.RPCInvocation) time.Duration
 			timeout, _ = time.ParseDuration(mTimeout)
 		}
 		// set timeout into invocation
-		ivc.SetAttachment(constant.TimeoutKey, strconv.Itoa(int(timeout.Milliseconds())))
+		ivc.SetAttachment(constant.TimeoutKey, strconv.Itoa(int(timeout.Nanoseconds())))

Review Comment:
   > Btw, I think the priority of timeout configuration is Method Level > Service Level > Consumer Level. Is it the same with dubbo? 
   
   In apache/dubbo, Consumer Level timeout always has higher priority than Provider Level timeout, so the first rule is `Consumer Level > Provider Level`.  Both Consumer and Provider have Method Level and Service Level timeout, so for both sides there's the second rule - `Method Level  > Service Level`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org