You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2015/10/11 23:06:27 UTC
[17/27] logging-log4j2 git commit: LOG4J2-935 added comment to
explain unusual logic
LOG4J2-935 added comment to explain unusual logic
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/ec8fd28f
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/ec8fd28f
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/ec8fd28f
Branch: refs/heads/LOG4J2-1136
Commit: ec8fd28fc52fa86d2ff229bb3f1e21eb1450a811
Parents: 2238958
Author: rpopma <rp...@apache.org>
Authored: Mon Oct 5 12:25:36 2015 +0200
Committer: Ralph Goers <rg...@nextiva.com>
Committed: Sun Oct 11 12:40:43 2015 -0700
----------------------------------------------------------------------
.../apache/logging/log4j/core/layout/AbstractStringLayout.java | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ec8fd28f/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
index de73e27..ae6f4c2 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
@@ -25,6 +25,10 @@ import org.apache.logging.log4j.core.LogEvent;
/**
* Abstract base class for Layouts that result in a String.
*/
+/*
+ * Implementation note: prefer String.getBytes(String) to String.getBytes(Charset) for performance reasons.
+ * See https://issues.apache.org/jira/browse/LOG4J2-935 for details.
+ */
public abstract class AbstractStringLayout extends AbstractLayout<String> {
/**