You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Hitesh Shah (JIRA)" <ji...@apache.org> on 2016/10/22 01:36:59 UTC

[jira] [Comment Edited] (TEZ-3471) Tez UI: PhantomJS dependency should be downloaded only when tests are run

    [ https://issues.apache.org/jira/browse/TEZ-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596499#comment-15596499 ] 

Hitesh Shah edited comment on TEZ-3471 at 10/22/16 1:36 AM:
------------------------------------------------------------

profile id names should ideally not contain spaces. 

What happens when doing -Dmaven.test.skip=true?

Is there a reason why the em-* dependencies are not ranges but hardcoded to a single version that needs to be changed each time around? Are these libraries changing in an incompatible way across each version? 




was (Author: hitesh):
profile id names should ideally not contain spaces. 

What happens when doing -Dmaven.test.skip=true?

Is there a reason why the em-* dependencies are not ranges but hardcoded to a single version that needs to be changed each time around? Are these libraries changing in an incompatible way across each version? 

<skipTests>false</skipTests> should not exist within the profile at all. Might have missed this in the previous review but this should not exist in a pom. 

> Tez UI: PhantomJS dependency should be downloaded only when tests are run
> -------------------------------------------------------------------------
>
>                 Key: TEZ-3471
>                 URL: https://issues.apache.org/jira/browse/TEZ-3471
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>              Labels: TezUI
>         Attachments: TEZ-3471.1.patch
>
>
> - PhantomJS is the most heavy dependency in TezUI. Its a headless browser for running UTs.
> - Right now its downloaded in all builds, when they are required only when tests are run.
> - This ticket is to disable downloading of PhantomJS when build is run with -DskipTests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)