You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by sboorlagadda <gi...@git.apache.org> on 2015/12/18 23:13:35 UTC
[GitHub] incubator-geode pull request: Disabled it until it is fixed, so th...
GitHub user sboorlagadda opened a pull request:
https://github.com/apache/incubator-geode/pull/62
Disabled it until it is fixed, so that sonar coverage succeeds
Disabled it until it is fixed, so that sonar coverage succeeds.
GEODE-701 tracks this test case failure and will be enabled once it is fixed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sboorlagadda/incubator-geode GEODE-701
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit fa5ec3b47ec3af9b72d23ce74145fb4c16c5dbbc
Author: Sai Boorlagadda <sb...@pivotal.io>
Date: 2015-12-18T22:11:12Z
Disabled it until it is fixed, so that sonar coverage succeeds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: SimpleMemoryAllocatorJUnitTest.testC...
Posted by sboorlagadda <gi...@git.apache.org>.
Github user sboorlagadda closed the pull request at:
https://github.com/apache/incubator-geode/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: SimpleMemoryAllocatorJUnitTest.testC...
Posted by sboorlagadda <gi...@git.apache.org>.
Github user sboorlagadda commented on the pull request:
https://github.com/apache/incubator-geode/pull/62#issuecomment-165912911
@upthewaterspout Thanks Dan for suggesting @Ignore.
This test currently failed only once on Geode_develop_UnitTests job but consistently failing on GemFire_develop_Sonar.
So disabling it until it is fixed so that code coverage analysis is not impacted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: SimpleMemoryAllocatorJUnitTest.testC...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the pull request:
https://github.com/apache/incubator-geode/pull/62#issuecomment-165916876
+1
On Fri, Dec 18, 2015 at 2:38 PM, Sai Boorlagadda <no...@github.com>
wrote:
> @upthewaterspout <https://github.com/upthewaterspout> Thanks Dan for
> suggesting @Ignore <https://github.com/Ignore>.
>
> This test currently failed only once on Geode_develop_UnitTests job but
> consistently failing on GemFire_develop_Sonar.
> So disabling it until it is fixed so that code coverage analysis is not
> impacted.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-geode/pull/62#issuecomment-165912911>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: SimpleMemoryAllocatorJUnitTest.testC...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the pull request:
https://github.com/apache/incubator-geode/pull/62#issuecomment-165910633
Is there are reason why this test should be disabled? I thought our practice is to not disable failing tests?
If you do need to disable the test, please use the @Ignore annotation and provide it a comment explaining why the test is ignored. This lets us easily see a list of ignored tests in jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---