[jira] [Comment Edited] (HIVE-14454) Vectorization: Varchar() -> String should not copy underlying buffers

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412207#comment-15412207 ] 

Sergey Shelukhin edited comment on HIVE-14454 at 8/8/16 6:23 PM:
-----------------------------------------------------------------

Nit: add comment explaining why it is ok to do? Actually if there's a good common interface or method or whatever for hashtables where the comment could be added to that effect (that the users rely on data being immutable) that would be even better.
Otherwise +1


was (Author: sershe):
Nit: add comment explaining why it is ok to do?
Otherwise +1

> Vectorization: Varchar() -> String should not copy underlying buffers
> ---------------------------------------------------------------------
>
>                 Key: HIVE-14454
>                 URL: https://issues.apache.org/jira/browse/HIVE-14454
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>    Affects Versions: 2.2.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>         Attachments: HIVE-14454.1.patch
>
>
> The base byte[] array for a ByteColumnVector is immutable - all changes are made to a scratch column.
> {code}
>   @Override
>   protected void func(BytesColumnVector outV, byte[][] vector, int[] start, int[] length, int i) {
>     outV.setVal(i, vector[i], start[i], length[i]);
>   }
> {code}
> the setVal copies the byte[] array, losing dictionary encoding in the process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)