You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by nd...@apache.org on 2020/08/10 17:19:08 UTC
[hbase] branch branch-2.3 updated: HBASE-24835 Normalizer should
log a successful run at INFO level
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 7c52684 HBASE-24835 Normalizer should log a successful run at INFO level
7c52684 is described below
commit 7c52684e7395b08f5969c9e1c230cbec4a379d90
Author: Nick Dimiduk <nd...@apache.org>
AuthorDate: Fri Aug 7 16:56:13 2020 -0700
HBASE-24835 Normalizer should log a successful run at INFO level
Signed-off-by: Sean Busbey <bu...@apache.org>
Signed-off-by: Viraj Jasani <vj...@apache.org>
---
.../main/java/org/apache/hadoop/hbase/master/HMaster.java | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
index 3c36dc9..2b5bb0e 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
@@ -31,6 +31,7 @@ import java.lang.reflect.InvocationTargetException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.UnknownHostException;
+import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
@@ -194,6 +195,7 @@ import org.apache.hadoop.hbase.security.UserProvider;
import org.apache.hadoop.hbase.trace.TraceUtil;
import org.apache.hadoop.hbase.util.Addressing;
import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.hadoop.hbase.util.HBaseFsck;
import org.apache.hadoop.hbase.util.HFileArchiveUtil;
import org.apache.hadoop.hbase.util.IdLock;
@@ -1886,6 +1888,7 @@ public class HMaster extends HRegionServer implements MasterServices {
* or normalization is globally disabled).
*/
public boolean normalizeRegions() throws IOException {
+ final long startTime = EnvironmentEdgeManager.currentTime();
if (regionNormalizerTracker == null || !regionNormalizerTracker.isNormalizerOn()) {
LOG.debug("Region normalization is disabled, don't run region normalizer.");
return false;
@@ -1903,6 +1906,7 @@ public class HMaster extends HRegionServer implements MasterServices {
return true;
}
+ int affectedTables = 0;
try {
final List<TableName> allEnabledTables =
new ArrayList<>(tableStateManager.getTablesInStates(TableState.State.ENABLED));
@@ -1931,6 +1935,7 @@ public class HMaster extends HRegionServer implements MasterServices {
continue;
}
+ affectedTables++;
// as of this writing, `plan.submit()` is non-blocking and uses Async Admin APIs to
// submit task , so there's no artificial rate-
// limiting of merge/split requests due to this serial loop.
@@ -1944,11 +1949,10 @@ public class HMaster extends HRegionServer implements MasterServices {
}
}
}
- int totalPlansSubmitted = submittedPlanProcIds.size();
- if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
- LOG.debug("Normalizer plans submitted. Total plans count: {} , procID list: {}",
- totalPlansSubmitted, submittedPlanProcIds);
- }
+ final long endTime = EnvironmentEdgeManager.currentTime();
+ LOG.info("Normalizer ran successfully in {}. Submitted {} plans, affecting {} tables.",
+ Duration.ofMillis(endTime - startTime), submittedPlanProcIds.size(), affectedTables);
+ LOG.debug("Normalizer submitted procID list: {}", submittedPlanProcIds);
} finally {
normalizationInProgressLock.unlock();
}