You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/01/04 19:08:48 UTC

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree 

Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12159


Change subject: Add Apache Kudu logo to the source tree
......................................................................

Add Apache Kudu logo to the source tree

These logos do not include the trademark (TM) symbol

Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
---
A img/media-src/ApacheKudu-logo-2016-07-huge.png
A img/media-src/ApacheKudu-logo-2016-07-white-huge.png
A img/media-src/ApacheKudu-logo-2016-07.eps.gz
3 files changed, 0 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/12159/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12159 )

Change subject: Add Apache Kudu logo to the source tree
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Grant asked for this, and these are not checked in anywhere else. They live on my hard drive and in an internal Cloudera Marketing JIRA. I thought gh-pages was a better choice than master because the files are pretty big and gh-pages is a dumping ground for large commits every release anyway.

Makes sense; could you synthesize part of that into the commit message?


-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 20:09:01 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12159 )

Change subject: Add Apache Kudu logo to the source tree
......................................................................


Patch Set 2: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 21:38:31 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12159 )

Change subject: Add Apache Kudu logo to the source tree
......................................................................

Add Apache Kudu logo to the source tree

These logos do not include the trademark (TM) symbol

I needed to get these off my personal hard drive; I thought gh-pages
was a better choice than master because the files are pretty big and
gh-pages is a dumping ground for large commits every release anyway.

Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Reviewed-on: http://gerrit.cloudera.org:8080/12159
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
A img/media-src/ApacheKudu-logo-2016-07-huge.png
A img/media-src/ApacheKudu-logo-2016-07-white-huge.png
A img/media-src/ApacheKudu-logo-2016-07.eps.gz
3 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12159 )

Change subject: Add Apache Kudu logo to the source tree
......................................................................


Patch Set 2:

> Could you synthesize part of that into the commit message?

Done


-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 21:21:55 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12159

to look at the new patch set (#2).

Change subject: Add Apache Kudu logo to the source tree
......................................................................

Add Apache Kudu logo to the source tree

These logos do not include the trademark (TM) symbol

I needed to get these off my personal hard drive; I thought gh-pages
was a better choice than master because the files are pretty big and
gh-pages is a dumping ground for large commits every release anyway.

Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
---
A img/media-src/ApacheKudu-logo-2016-07-huge.png
A img/media-src/ApacheKudu-logo-2016-07-white-huge.png
A img/media-src/ApacheKudu-logo-2016-07.eps.gz
3 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/12159/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12159 )

Change subject: Add Apache Kudu logo to the source tree
......................................................................


Patch Set 1:

Grant asked for this, and these are not checked in anywhere else. They live on my hard drive and in an internal Cloudera Marketing JIRA. I thought gh-pages was a better choice than master because the files are pretty big and gh-pages is a dumping ground for large commits every release anyway.


-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 19:49:06 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add Apache Kudu logo to the source tree

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12159 )

Change subject: Add Apache Kudu logo to the source tree
......................................................................


Patch Set 1:

What's the motivation?


-- 
To view, visit http://gerrit.cloudera.org:8080/12159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab7185407e23c1c6c2620723ca44910248b6462
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 19:13:34 +0000
Gerrit-HasComments: No