[jira] [Resolved] (HDFS-8804) Erasure Coding: use DirectBufferPool in DFSStripedInputStream for buffer allocation

["Jing Zhao (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jing Zhao resolved HDFS-8804.
-----------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: HDFS-7285

I've committed this to the feature branch. Thank you guys for the review!

bq. we can at least assert alignedStripe.range.spanInBlock is no larger than cellSize

This is guaranteed by the logic in {{readOneStripe}}. Thus my feeling here is the assertion is unnecessary. Also we don't have this assertion for data block buffer.

> Erasure Coding: use DirectBufferPool in DFSStripedInputStream for buffer allocation
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-8804
>                 URL: https://issues.apache.org/jira/browse/HDFS-8804
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>             Fix For: HDFS-7285
>
>         Attachments: HDFS-8804.000.patch, HDFS-8804.001.patch
>
>
> Currently we directly allocate direct ByteBuffer in DFSStripedInputstream for the stripe buffer and the buffers holding parity data. It's better to get ByteBuffer from DirectBufferPool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)