You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Eric Dalquist (JIRA)" <ji...@apache.org> on 2008/01/09 22:17:34 UTC

[jira] Created: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
---------------------------------------------------------------------

                 Key: PLUTO-462
                 URL: https://issues.apache.org/jira/browse/PLUTO-462
             Project: Pluto
          Issue Type: Bug
          Components: portlet container
    Affects Versions: 1.1.4
            Reporter: Eric Dalquist
             Fix For: 1.1.5
         Attachments: modeStateEquals.patch

The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Doremus updated PLUTO-462:
--------------------------------

        Fix Version/s: 2.0-refactoring
                       2.0.0
    Affects Version/s: 2.0-refactoring

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 2.0-refactoring, 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 2.0.0, 2.0-refactoring, 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Elliot Metsger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliot Metsger updated PLUTO-462:
---------------------------------

        Fix Version/s:     (was: 2.0.0)
    Affects Version/s: 2.0.0

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Doremus updated PLUTO-462:
--------------------------------

    Fix Version/s: 2.0.0

Attached patch (modeStateEquals.patch) will not work with trunk code.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 2.0.0, 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Elliot Metsger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliot Metsger resolved PLUTO-462.
----------------------------------

    Resolution: Fixed

Committed 1.1.x 611007.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Elliot Metsger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliot Metsger resolved PLUTO-462.
----------------------------------

    Resolution: Fixed

See PLUTO-468 for the issue opened against 2.0.0.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616752#action_12616752 ] 

Craig Doremus commented on PLUTO-462:
-------------------------------------

Manually applied patch to pluto-2.0-spi-refactoring branch in SVN rev 679653.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616748#action_12616748 ] 

Craig Doremus commented on PLUTO-462:
-------------------------------------

Manually applied patch to trunk in SVN rev 679648.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Doremus reopened PLUTO-462:
---------------------------------


This issue needs to be resolved in the trunk (version 2.0.0) too.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 2.0.0, 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-462) isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

Posted by "Eric Dalquist (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist updated PLUTO-462:
--------------------------------

    Attachment: modeStateEquals.patch

Changes the equality tests to ignore case.

> isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks
> ---------------------------------------------------------------------
>
>                 Key: PLUTO-462
>                 URL: https://issues.apache.org/jira/browse/PLUTO-462
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 1.1.4
>            Reporter: Eric Dalquist
>             Fix For: 1.1.5
>
>         Attachments: modeStateEquals.patch
>
>
> The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.