You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "spacewander (via GitHub)" <gi...@apache.org> on 2023/02/03 14:43:22 UTC
[GitHub] [skywalking-rover] spacewander opened a new pull request, #76: chore: improve readablity
spacewander opened a new pull request, #76:
URL: https://github.com/apache/skywalking-rover/pull/76
Signed-off-by: spacewander <sp...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] spacewander commented on a diff in pull request #76: chore: improve readablity
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on code in PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#discussion_r1096467162
##########
bpf/profiling/network/args.h:
##########
@@ -244,9 +244,11 @@ static __inline struct socket_buffer_reader_t* read_socket_data(struct sock_data
if (size > MAX_PROTOCOL_SOCKET_READ_LENGTH) {
size = MAX_PROTOCOL_SOCKET_READ_LENGTH;
}
+ // use & to work around an issue in kernel verifier.
+ // See https://github.com/apache/skywalking/discussions/10273
Review Comment:
@wu-sheng
I replace this with the original issue, so people can get rid of the workaround once the original issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] wu-sheng commented on a diff in pull request #76: chore: improve readablity
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#discussion_r1096390807
##########
bpf/profiling/network/args.h:
##########
@@ -244,9 +244,11 @@ static __inline struct socket_buffer_reader_t* read_socket_data(struct sock_data
if (size > MAX_PROTOCOL_SOCKET_READ_LENGTH) {
size = MAX_PROTOCOL_SOCKET_READ_LENGTH;
}
+ // use & to work around an issue in kernel verifier.
+ // See https://github.com/apache/skywalking/discussions/10273
Review Comment:
Please put a summary in the comments directly.
We don't recommend to put a link in codes. The issue could be edited or be updated later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] wu-sheng commented on pull request #76: chore: improve readablity
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1481388118
@mrproliu This change seem breaking something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] mrproliu commented on pull request #76: chore: improve readablity
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1416685056
I think [there](https://github.com/apache/skywalking-rover/blob/main/bpf/profiling/network/netmonitor.c#L285) should also be an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] wu-sheng commented on pull request #76: chore: improve readablity
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1418349549
e2e fails, please recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] spacewander commented on pull request #76: chore: improve readablity
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1482108471
> @spacewander This PR had been open for months, are you still working on this?
I still could not figure out why the e2e tests are not passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] wu-sheng commented on pull request #76: chore: improve readablity
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1481340664
@spacewander This PR had been open for months, are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] spacewander commented on pull request #76: chore: improve readablity
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1482123856
I decide to close this PR first, as I am still busy working on other stuff. Maybe someone else can work on it and figure out why the tests are not passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] mrproliu commented on pull request #76: chore: improve readablity
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1482109912
> > @spacewander This PR had been open for months, are you still working on this?
>
> I still could not figure out why the e2e tests are not passed.
It looks like the eBPF verification failed. Have you tried to download the [E2E logs](https://github.com/apache/skywalking-rover/suites/11762446093/artifacts/613197130) or try to run it on your local machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] spacewander commented on pull request #76: chore: improve readablity
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#issuecomment-1482116866
I tried to read the logs but didn't find out why. As for the setup the e2e environment, I am too busy recently so I didn't try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rover] spacewander closed pull request #76: chore: improve readablity
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander closed pull request #76: chore: improve readablity
URL: https://github.com/apache/skywalking-rover/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org