You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2013/03/05 22:51:12 UTC
Review Request: CLOUDSTACK-1465: We need to pass an Array instead of a List
to SearchCriteria.Op.IN operator, causing listZones returns NULL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9760/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
This patch fixed the blocker defect: CLOUDSTACK-1465 - List Zones returns null under create instance when logged is as user. It is caused by a misuse of SearchCriteria.andOr method, where we should pass an Array instead of List in case of IN operator.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1465.
Diffs
-----
server/src/com/cloud/api/query/QueryManagerImpl.java 746e8cb
Diff: https://reviews.apache.org/r/9760/diff/
Testing
-------
Verified with QA's failed scenario.
Thanks,
Min Chen
Re: Review Request: CLOUDSTACK-1465: We need to pass an Array instead of a
List to SearchCriteria.Op.IN operator, causing listZones returns NULL
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9760/#review17426
-----------------------------------------------------------
Ship it!
Applied to 4.1:
commit 7e12ffe4de375542141a1ab2b4f584a3b87f20b0
Author: Min Chen <mi...@citrix.com>
Date: Tue Mar 5 13:46:06 2013 -0800
CLOUDSTACK-1465: We should pass array instead of a List for SearchCriteria.Op.IN as value.
- Chip Childers
On March 5, 2013, 9:51 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9760/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 9:51 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> This patch fixed the blocker defect: CLOUDSTACK-1465 - List Zones returns null under create instance when logged is as user. It is caused by a misuse of SearchCriteria.andOr method, where we should pass an Array instead of List in case of IN operator.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1465.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java 746e8cb
>
> Diff: https://reviews.apache.org/r/9760/diff/
>
>
> Testing
> -------
>
> Verified with QA's failed scenario.
>
>
> Thanks,
>
> Min Chen
>
>