You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/05/21 15:43:20 UTC

[GitHub] [zeppelin] cuspymd opened a new pull request #4125: [ZEPPELIN-5388] Polish realm package of zeppelin-server

cuspymd opened a new pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125


   ### What is this PR for?
   - Add `final` keyword to variables which are not re-assigned
   - Delete unnecessary and unused codes
   
   
   ### What type of PR is it?
   [Refactoring]
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5388
   
   ### How should this be tested?
   * CI
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4125: [ZEPPELIN-5388] Polish realm package of zeppelin-server

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] cuspymd commented on pull request #4125: [ZEPPELIN-5388] Polish realm package of zeppelin-server

Posted by GitBox <gi...@apache.org>.
cuspymd commented on pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125#issuecomment-849701071


   > LGTM, thanks @cuspymd I made a hotfix for the flink CI failure, could you rebase your PR and trigger the CI again ?
   
   I have rebased latest commit and triggered the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4125: [ZEPPELIN-5388] Polish realm package of zeppelin-server

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125#issuecomment-850415778


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4125: [ZEPPELIN-5388] Polish realm package of zeppelin-server

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125#issuecomment-849326766


   LGTM, thanks @cuspymd I made a hotfix for the flink CI failure, could you rebase your PR and trigger the CI again ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org