You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Karl Wettin (JIRA)" <ji...@apache.org> on 2006/05/23 23:31:29 UTC

[jira] Created: (LUCENE-575) SpellChecker min score is increased by time

SpellChecker min score is increased by time
-------------------------------------------

         Key: LUCENE-575
         URL: http://issues.apache.org/jira/browse/LUCENE-575
     Project: Lucene - Java
        Type: Bug

  Components: Search  
    Versions: 1.9    
    Reporter: Karl Wettin
    Priority: Blocker


The minimum score, an instance variable, is modified in a search. That is wrong, since it makes it 1. thread unsafe and 2. not working. 

Lucky enought it is only used from the one and same method call, so I simply compied the instance variable to a local method variable.

        float min = this.min; 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Re: [jira] Commented: (LUCENE-575) SpellChecker min score is increased by time

Posted by Chris Hostetter <ho...@fucit.org>.
: This is just another push to get the patch committed.

Patches with unit tests demonstrating the problem (and the fix) are more
likely to get attention.


-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-575) SpellChecker min score is increased by time

Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/LUCENE-575?page=comments#action_12413635 ] 

Karl Wettin commented on LUCENE-575:
------------------------------------

This is just another push to get the patch committed.

> SpellChecker min score is increased by time
> -------------------------------------------
>
>          Key: LUCENE-575
>          URL: http://issues.apache.org/jira/browse/LUCENE-575
>      Project: Lucene - Java
>         Type: Bug

>   Components: Search
>     Versions: 1.9
>     Reporter: Karl Wettin
>     Priority: Blocker
>  Attachments: SpellChecker.java.diff
>
> The minimum score, an instance variable, is modified in a search. That is wrong, since it makes it 1. thread unsafe and 2. not working. 
> Lucky enought it is only used from the one and same method call, so I simply compied the instance variable to a local method variable.
>         float min = this.min; 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-575) SpellChecker min score is increased by time

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LUCENE-575?page=all ]
     
Yonik Seeley resolved LUCENE-575:
---------------------------------

    Fix Version: 2.1
     Resolution: Fixed
      Assign To: Yonik Seeley

I just commited this.  Thanks Karl!

> SpellChecker min score is increased by time
> -------------------------------------------
>
>          Key: LUCENE-575
>          URL: http://issues.apache.org/jira/browse/LUCENE-575
>      Project: Lucene - Java
>         Type: Bug

>   Components: Search
>     Versions: 1.9
>     Reporter: Karl Wettin
>     Assignee: Yonik Seeley
>     Priority: Blocker
>      Fix For: 2.1
>  Attachments: SpellChecker.java.diff
>
> The minimum score, an instance variable, is modified in a search. That is wrong, since it makes it 1. thread unsafe and 2. not working. 
> Lucky enought it is only used from the one and same method call, so I simply compied the instance variable to a local method variable.
>         float min = this.min; 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-575) SpellChecker min score is increased by time

Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LUCENE-575?page=all ]

Karl Wettin updated LUCENE-575:
-------------------------------

    Attachment: SpellChecker.java.diff

I would have to say this is for 2.0 as the SpellCheck does not work without it in most cases.

> SpellChecker min score is increased by time
> -------------------------------------------
>
>          Key: LUCENE-575
>          URL: http://issues.apache.org/jira/browse/LUCENE-575
>      Project: Lucene - Java
>         Type: Bug

>   Components: Search
>     Versions: 1.9
>     Reporter: Karl Wettin
>     Priority: Blocker
>  Attachments: SpellChecker.java.diff
>
> The minimum score, an instance variable, is modified in a search. That is wrong, since it makes it 1. thread unsafe and 2. not working. 
> Lucky enought it is only used from the one and same method call, so I simply compied the instance variable to a local method variable.
>         float min = this.min; 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org